Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more modern reference for input text #14983

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 27, 2024

This just replaces Request::old() with the more modern old() for form input.

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jun 27, 2024

PR Summary

  • Updated input field attributes in various PHP files
    Several PHP files saw changes in their input field attributes. The "Request::old()" function, which retrieved an old input value from a user session, has been replaced with the simpler "old()" function.

  • Replaced 'Request::old' with 'old' in blade.php files
    In more than 20 .blade.php view files, the function 'Request::old()' has been replaced with the more straightforward 'old()' function. The change streamlines the retrieval of previous input values and form data supplied by the user.

  • Updated values for specific fields in numerous resources/views/settings files
    Certain settings files were modified to replace 'Request::old' with 'old' for various specific fields such as 'locale', 'email_domain', 'site_name' and others.

  • Modification in statuslabel fields in edit.blade.php
    The 'Request::old' function was replaced with 'old' for the 'color', 'show_in_nav', and 'default_label' input fields making attribute data retrieval unified across the application.

  • Added 'old()' method for certain form fields
    The 'old()' method was added to some hidden input field and select statements which aids in storing user input data in the user session, thus, preserving form data during page refreshes.

These changes make our codebase more consistent and easier to maintain, and they improve the user experience by preserving data that users have entered into forms, even if the page is refreshed.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't pull this down to test each file changed but looking at the diff to make sure Request::old was the only thing removed in each instance should cover it 👍🏾

@snipe snipe merged commit f22e99a into develop Jul 2, 2024
9 checks passed
@snipe snipe deleted the fixes/use_more_modern_request_syntax_in_blades branch July 2, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants