Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional translation strings #14925

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Additional translation strings #14925

merged 5 commits into from
Jun 24, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 20, 2024

This replaces some hard-coded strings with the appropriate translation strings. I could use sanity checking on the string locations though - my eyes are starting to cross. 😬

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jun 20, 2024

PR Summary

  • Enhancements to LoginController
    Various user-facing text strings in the application's login controller have been updated for internationalization. This means that the messages can be easily translated into other languages which can help improve the user experience for non-English speakers.

  • Updates to CheckForTwoFactor middleware
    Updates were made to the two-factor authentication module. The changes include replacing hard-coded messages with translatable text strings. These alterations aim at making the two-factor authentication process easier to understand for users across diverse languages.

  • Additions to General Language Files
    Two new lines were added to the general language file, this includes messages for 'two-factor code' and 'requestable items'. The aim here is to make these modules more adaptable to different languages.

  • Modifications to the Blade Templates
    Updates were made to the requestable-assets and default blade templates. Hard-coded, non-translatable text has been replaced with translatable strings from the general language file. This change is aimed at improving the multi-language support across the application's interface.

Signed-off-by: snipe <snipe@snipe.net>
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏾 :shipit:

@snipe snipe merged commit 294fb1f into develop Jun 24, 2024
8 checks passed
@snipe snipe deleted the fixes/added_2fa_string branch June 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants