Possible fix for proxy/reverse proxy #14896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should override Symfony's parsing of URLs to prevent folks from having to add the
APP_FORCE_TLS=true
to their.env
when they are running behind a proxy/reverse proxy. I'm still not 100% sure why this change was needed when it wasn't in previous versions, but I think this will fix the issue.This will still let you force override (for whatever possible reason) if your URL schema is not https (which you definitely shouldn't do, in general), but it basically changes things so that if you state your APP_URL to be
https://
, we WILL enforce secure urls.Many thanks to @uberbrady and all of the amazing folks in the PHP Portugal Telegram group for helping us rubberduck this.