Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] consider transition layers as bottom layers for purposes of SB/LB/SN/LN navigation #896

Closed
rinqu-eu opened this issue Jul 4, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@rinqu-eu
Copy link

rinqu-eu commented Jul 4, 2024

Problem to solve

When using SB/LB/SN/LN navigation;
if the raft is tall enough to be split across the bottom layers and the transition layers
using either LB or LN will most likely return one of the raft layers.

Example: when we have 5 bottom layers and 10 transition layers. Both return the raft as being the biggest mass
current

Possible solutions

1st choice: Marking transition layers as 'bottom' instead of 'normal'.
2nd choice: add a separate category for transition layers, and add ST and LT navigation.

Example: when we change the bottom layers count to 15 to simulate transition layers being included, LN actually returns part of the print as the biggest mass.
changed

Files

No response

@rinqu-eu rinqu-eu added the enhancement New feature or request label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

@sn4k3
Copy link
Owner

sn4k3 commented Jul 5, 2024

If the raft is part of both bottom and normal layers and is the largest mass on the file that is the expected behavior and returning exactly what it should, this not a issue and the behavior will not change regarding the terms SB/LB/SN/LN. It foreach the layer group the return the most pixel layer.

There is no absolute way to detect what is a raft/support/model which also vary from user to user / print to print.
If you want to know the largest mass of the model you can code a snippet code to run on File - Terminal which ignore first n layers defined by you. So if your rafts are never taller than x you can skip that layers and compute with the rest.

@rinqu-eu
Copy link
Author

rinqu-eu commented Jul 5, 2024

I understand that this is an intended behaviour and it is returning exactly what it's supposed to.
I didn't suggest autodetecting rafts/supports/models. I've only suggested that transition layers get treated as bottom (as in IsBottomLayer = true) or separate 'transition' layers.

Looking at the code now, FirstTransitionLayer and FirstNormalLayer seem to return the same thing, where in my mind, I'd assume that the order goes bottom -> transition -> normal

I'm basically suggesting, that transition layers should be a separate category, instead of having overlap with normal layers based on the fact that they have a different exposure time.

@sn4k3
Copy link
Owner

sn4k3 commented Jul 5, 2024

In common case the transition layers starts on first normal layer and goes on fading. It does not create a gap between bottom and normals "group".
Bottom and normal layers are just terms to differentiate two groups of settings.
As for code is safer to just have two groups that always exists, than 3 groups that 1 could not, that will remain un-change.

In terminal you can calculate what you suggest by add the first normal with transition layer count

@rinqu-eu
Copy link
Author

rinqu-eu commented Jul 6, 2024

I will implement my case via the terminal then, thank you

@rinqu-eu rinqu-eu closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants