Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Difference view with multiple layers. #602

Open
bartoszek opened this issue Nov 8, 2022 · 5 comments
Open

[FEATURE REQUEST] Difference view with multiple layers. #602

bartoszek opened this issue Nov 8, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bartoszek
Copy link

Is your feature request related to a problem? Please describe

Would be nice to have ability to view multiple layers in the difference view to assess how many layers there's till island gets reconnected without having to slowly cycle through a bunch of layers.

Describe the solution you'd like

Add a two alternating colors with a value gradient, showing multiple layers in the difference view.

Screenshots

Example of 4 layers difference view.
xenomorph_torso_head_hollowed_35,5ml_8h50m_difference_proposal

@bartoszek bartoszek added the enhancement New feature or request label Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

@bartoszek
Copy link
Author

Nex step would be to add voxel rendering to inspect print file in glorious 3d 😏

@sn4k3
Copy link
Owner

sn4k3 commented Nov 9, 2022

how many layers there's till island gets reconnected

This is a performance problem, is not viable to do it "live" while you change layers. Anything that require comparing images, search for a feature and iterate is very slow and can't afford in a live nativation.

...add voxel rendering to inspect print file..

Do not expect that to happen soon either, the 3d mesh reconstruction from 2D is very slow and generate ton of triangles which is impossible for most machines to render from RAM. Try to export your layers to mesh using the layer actions, open in a software and see the result

@bartoszek
Copy link
Author

bartoszek commented Nov 11, 2022

the 3d mesh reconstruction from 2D is very slow and generate ton of triangles

No no no, just do a voxel rendering, like the VTK does: just color the voxel in accordance with detected issue and set transparency with layer makes and type of issue.
1ab4daf8846d19097b43751c3eb8cf1ac67486c3.gif
Perhaps it would be beneficial performance wise to use Kitware.VTK to display the layer view after all ¯⁠\⁠_⁠(⁠ツ⁠)⁠_⁠/⁠¯
https://vtk.org/Wiki/VTK/CSharp/ActiViz.NET
vtkImageCroppingWidget.gif
This could give a possibility to e.g: dig arbitrary orientation 3D holes in the print by placing cylinder in the viewport, and masking voxels overlapping with its inside.

@sn4k3
Copy link
Owner

sn4k3 commented Nov 11, 2022

openCV compiles the VTK module but never tried, documentation is lacking.
An extra problem is to make the render to work integrated, it must be displayed inside current UI framework and integrate with other elements which is no easy task. I'm still waiting for thier openTK implementation, currently openGL can't be used on windows bug-free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants