Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parcel-bundler with parcel #387

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Replace parcel-bundler with parcel #387

merged 1 commit into from
Jan 28, 2020

Conversation

fregante
Copy link
Contributor

Fixes #381

This would probably be a breaking release because it requires users to also replace parcel-bundler

@vercel
Copy link

vercel bot commented Jan 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/gregberge/svgr/15f0uiq3j
✅ Preview: https://svgr-git-fork-fregante-parcel.gregberge.now.sh

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #387 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          30       30           
  Lines         518      518           
  Branches      142      142           
=======================================
  Hits          443      443           
  Misses         62       62           
  Partials       13       13
Impacted Files Coverage Δ
packages/parcel-plugin-svgr/src/asset.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b806841...bbda6b5. Read the comment docs.

@gregberge
Copy link
Owner

Hello @fregante, could you also update the parcel example in the examples directory please?

@fregante
Copy link
Contributor Author

I did a global search/replace, there are no other instances of parcel-bundler. I already updated a couple of files in /examples

files

@gregberge gregberge merged commit d09bcd5 into gregberge:master Jan 28, 2020
@fregante fregante deleted the parcel branch January 29, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with parcel package (only parcel-bundler)
2 participants