Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make this crate no_std #28

Closed
notgull opened this issue Aug 28, 2022 · 2 comments
Closed

Make this crate no_std #28

notgull opened this issue Aug 28, 2022 · 2 comments

Comments

@notgull
Copy link
Member

notgull commented Aug 28, 2022

If this crate were no_std, it would allow crates like async-lock and async-channel to be used on no_std as well. I envision an API with a default std feature, and without it this crate would not depend on parking (and the wait API would disappear as well).

However, the current version of the code uses a Mutex to lock the linked list containing event listeners. Theoretically, we could replace this with an atomic linked list similar to the one used in concurrent-queue.

This would help smol be able to be used in embedded systems. Any thoughts on this?
@taiki-e
Copy link
Collaborator

taiki-e commented Aug 29, 2022

If this can be implemented without spinlock, I tend to accept this.

@notgull notgull mentioned this issue Sep 5, 2022
Closed
@notgull notgull mentioned this issue Nov 5, 2022
Merged
@notgull
Copy link
Member Author

notgull commented Nov 11, 2022

Resolved by #34

@notgull notgull closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a new algorithm to make this crate no_std smol-rs/event-listener
2 participants
@notgull @taiki-e