Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PFG 1.7.x not compatible with jQuery 1.9+ #188

Open
petschki opened this issue Jan 12, 2017 · 2 comments
Open

PFG 1.7.x not compatible with jQuery 1.9+ #188

petschki opened this issue Jan 12, 2017 · 2 comments

Comments

@petschki
Copy link

due to $.live calls ... can we remove them in 1.7-maintenance branch?
@mauritsvanrees
Copy link
Collaborator

1.7.x still supports Plone 4.1, which means jQuery 1.4.4.
Instead of live, on was introduced in jQuery 1.7, so that seems a bridge too far.
If I read http://api.jquery.com/live/ correctly, this means we should use delegate. I don't think I ever used that one. :-) But that seems the best to me. A pull request would be welcome.

@petschki
Copy link
Author

petschki commented Jan 13, 2017 •
edited
Loading

Thanks for the hint with .delegate() ... me never used that either ... I'll request a pull later today.

@petschki petschki mentioned this issue Jan 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauritsvanrees @petschki