Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piral-breadcrumbs dependency on react-router v5 #681

Closed
2 of 3 tasks
chris-nolan opened this issue Mar 28, 2024 · 3 comments
Closed
2 of 3 tasks

piral-breadcrumbs dependency on react-router v5 #681

chris-nolan opened this issue Mar 28, 2024 · 3 comments
Labels
bug Something isn't working plugin Covered by an opt-in plugin for Piral. react Concerns the React part in Piral.
Milestone
1.5.3

Comments

@chris-nolan
Copy link

Bug Report

The piral-breadcrumbs plugin has a dependency on react-router v5, this makes it incompatible with shells that are using v6.

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

Piral v1.5.2

Steps to Reproduce

  1. Add react-router v6 as a dependency in a shell
  2. Try and use react-breadcrumbs in shell

Expected behavior

Should be usable with v5 or v6 like other plugins/piral shell

Actual behavior

Errors occur/plugin not usable
@chris-nolan chris-nolan added the bug Something isn't working label Mar 28, 2024
@FlorianRappl FlorianRappl added this to the 1.5.3 milestone Mar 28, 2024
@FlorianRappl FlorianRappl added plugin Covered by an opt-in plugin for Piral. react Concerns the React part in Piral. in-testing The item is already out in preview and can be tested. and removed in-testing The item is already out in preview and can be tested. labels Mar 28, 2024
@FlorianRappl
Copy link
Contributor

Is part of 1.5.3!

(Please test with the next version yourself - in my tests everything seems to be fine with this update; piral-breadcrumbs now works independent of React Router / the React Router version.)

@chris-nolan
Copy link
Author

Awesome! Will check tomorrow.

@chris-nolan
Copy link
Author

Yep, all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plugin Covered by an opt-in plugin for Piral. react Concerns the React part in Piral.
Projects
None yet
Milestone
1.5.3
Development

No branches or pull requests
2 participants
@FlorianRappl @chris-nolan