Decorate emitters with PublisherDecorators #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
requested changes
Oct 24, 2023
...messaging-provider/src/main/java/io/smallrye/reactive/messaging/providers/wiring/Wiring.java
Outdated
Show resolved
Hide resolved
...messaging-provider/src/main/java/io/smallrye/reactive/messaging/providers/wiring/Wiring.java
Show resolved
Hide resolved
ozangunalp
force-pushed
the
publisher_decorator_emitter
branch
from
7c3969f
to
2f759a1
Compare
|
@cescoffier pushed a fix for Kafka transactions. It appears that applying ContextDecorator there changes the tx flow order, flushing and commiting the Tx before records are sent. Now it captures sent record Uni's and makes sure that all of them are sent before flusing and committing. |
|
@cescoffier shall we get this in ? |
|
Yes! |
Merged
ozangunalp
added a commit
to ozangunalp/smallrye-reactive-messaging
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2332
May supersede #2336