Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some synchronized blocks #2289

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

ozangunalp
Copy link
Collaborator

Replace synchronized blocks in Emitter and Kafka connector with ReentrantLock

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #2289 (17f6675) into main (8bfcb7f) will increase coverage by 0.11%.
The diff coverage is 82.72%.

❗ Current head 17f6675 differs from pull request most recent head cadb166. Consider uploading reports for the commit cadb166 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2289      +/-   ##
============================================
+ Coverage     77.86%   77.98%   +0.11%     
- Complexity     3711     3750      +39     
============================================
  Files           302      312      +10     
  Lines         12393    12555     +162     
  Branches       1588     1601      +13     
============================================
+ Hits           9650     9791     +141     
- Misses         2022     2036      +14     
- Partials        721      728       +7     
Files Changed Coverage Δ
...ive/messaging/providers/extension/EmitterImpl.java 100.00% <ø> (ø)
...ssaging/providers/extension/LegacyEmitterImpl.java 100.00% <ø> (ø)
...messaging/providers/extension/AbstractEmitter.java 71.95% <64.00%> (+2.61%) ⬆️
...ging/kafka/transactions/KafkaTransactionsImpl.java 91.66% <83.33%> (+0.87%) ⬆️
.../providers/helpers/AcknowledgementCoordinator.java 91.42% <89.28%> (+2.14%) ⬆️
...ging/kafka/impl/KafkaRecordStreamSubscription.java 81.25% <100.00%> (+0.14%) ⬆️
...rye/reactive/messaging/kafka/impl/RecordQueue.java 85.18% <100.00%> (+1.85%) ⬆️

... and 21 files with indirect coverage changes

@ozangunalp ozangunalp merged commit 4364cea into smallrye:main Sep 21, 2023
5 checks passed
@ozangunalp ozangunalp deleted the replace_some_synchronized_blocks branch September 21, 2023 12:17
@ozangunalp ozangunalp added this to the 4.10.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants