-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulsar Traces are not always propagated #2519
Comments
michalcukierman
added a commit
to streamx-dev/smallrye-reactive-messaging
that referenced
this issue
Mar 9, 2024
michalcukierman
added a commit
to streamx-dev/smallrye-reactive-messaging
that referenced
this issue
Mar 9, 2024
During the tests, I discovered that more changes are required. Pushed the second commit. In the second case it's also about re-using the same instance of a map between the PulsarTrace and the MessageBuilder. Please feel free to reject this PR and propose other solutions that would work. |
ozangunalp
added a commit
to ozangunalp/smallrye-reactive-messaging
that referenced
this issue
Mar 13, 2024
michalcukierman
added a commit
to streamx-dev/smallrye-reactive-messaging
that referenced
this issue
Mar 13, 2024
michalcukierman
added a commit
to streamx-dev/smallrye-reactive-messaging
that referenced
this issue
Mar 13, 2024
ozangunalp
added a commit
that referenced
this issue
Mar 13, 2024
#2519 Fix: PulsarOutgoingChannel tracing properties propagation
ozangunalp
pushed a commit
that referenced
this issue
Jul 25, 2024
(cherry picked from commit 756a3e8)
ozangunalp
pushed a commit
that referenced
this issue
Jul 25, 2024
(cherry picked from commit f694fab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a regression introduced by #2456.
Tracing properties from incoming Pulsar messages are not propagated to outgoing Pulsar messages.
The change is in PulsarTrace.java:
before:
after:
It was introduced to ensure that the map is modifiable because it's required during producing outgoing traces.
Unfortunately, it introduced a regression in PulsarOutgoingChannel. We expect that the changes in properties will be propagated into the state of the trace:
I think that the correct solution could look like:
This happens only when PulsarOutgoingMessageMetadata is not used.
The text was updated successfully, but these errors were encountered: