Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the impsort Maven plugin #376

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Feb 10, 2023

The version 1.8.0 is the first version that works correctly with Maven 3.9.0+, see [1][2].

[1] revelc/impsort-maven-plugin#64
[2] revelc/impsort-maven-plugin#65

The version 1.8.0 is the first version that works correctly
with Maven 3.9.0+, see [1][2].

[1] revelc/impsort-maven-plugin#64
[2] revelc/impsort-maven-plugin#65
@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 10, 2023

Hmm, except it requires Java 11... :-/

@radcortez
Copy link
Member

Yes, I noticed the impsort issue yesterday with GH Windows builds. I was wondering why dependabot didn't update the plugin, and I've found this: #338 :D

Our plan was to move to 11 with the Jakarta update, which is now done on Quarkus. I think it will be fine to mandate 11 from now on and only update parent in the Jakarta branches (or main if it is already Jakarta).

We do need to fix the Maven version in the build pipelines to be able to build the javax versions.

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 10, 2023

Hah, I looked for dependabot PR but didn't look far enough into the past :-)

Yeah I'm doing the same on Fault Tolerance: merging jakarta into main, which includes bumping to 11. So long, Java 8! :-)

@radcortez
Copy link
Member

To fix the Maven version in the CI:
smallrye/smallrye-config@6ddbf89

I think we should merge the Jakarta POM into the main one and drop it, meaning that instead of using smallrye-parent-jakarta, you use smallrye-parent again and bump Java to 11. This would mean the last parent version for the javax dependencies is 38. If we need further updates, we either have to do a x.y release or override the SR project directly. Effectively, everything that is javax should be in maintenance mode now, so I do not expect requiring bumping their parent versions.

@cescoffier
@sberyozkin
@aureamunoz
@jmartisk
@xstefank
@jponge
@brunobat
@MikeEdgar
@phillip-kruger
@ozangunalp

Does anyone have any concerns or restrictions?

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 10, 2023

I agree with removing the javax parent POM and keeping only the jakarta one (even though I use build-parent and manage dependencies myself :-) ).

Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for us on the Mutiny galaxy

Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thank you sir, run into this during my weekend testing and was just about to look where the version is defined :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impsort-maven-plugin shall work with Java 9+
4 participants