Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC add changelog to docs #88

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

adrinjalali
Copy link
Member

This is the initial changelog, we don't have to be detailed here since it's the first release.

cc @skops-dev/maintainers

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we expect contributors to add to the changes.rst or do we collect all changes ourselves before the release? If the former, we should also amend the CONTRIBUTING.rst.

Do we want to later differentiate between kinds of changes, e.g. features vs bugfix vs breaking changes etc.?

docs/changes.rst Outdated Show resolved Hide resolved
@adrinjalali
Copy link
Member Author

If the former, we should also amend the CONTRIBUTING.rst.

Added authors, refinements to the contributing guide is coming in a separate PR.

Looks good. Do we expect contributors to add to the changes.rst or do we collect all changes ourselves before the release?

I also rather each PR add their line in the changelog.

Do we want to later differentiate between kinds of changes, e.g. features vs bugfix vs breaking changes etc.?

We can differentiate between those different types of changes, don't mind.

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@merveenoyan merveenoyan merged commit c4ed674 into skops-dev:main Aug 10, 2022
@adrinjalali adrinjalali deleted the changelog branch August 10, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants