Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC readme expansion #80

Merged
merged 2 commits into from
Aug 9, 2022
Merged

DOC readme expansion #80

merged 2 commits into from
Aug 9, 2022

Conversation

adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Aug 9, 2022

A bit of more README

fixes #77

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. I have two suggestions, up to you if you want to follow them.

At the moment, it includes the following features:

- ``skops.hub_utils``: tools to create a model repository to be stored on
`Hugging Face Hub <https://hf.co/models>`__, mainly through
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly through skops.hub_utils.init and skops.hub_utils.push.

I think this doesn't add much for the reader. I think the added value (apart from storing and sharing) rather comes from the inference widget. WDYT?

- ``skops.hub_utils``: tools to create a model repository to be stored on
`Hugging Face Hub <https://hf.co/models>`__, mainly through
``skops.hub_utils.init`` and ``skops.hub_utils.push``.
- ``skops.card``: tools to create a model card explaining what the model does
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding something along the lines of "automatically populating" the model card? I know not everything is populated automatically, but some stuff is, which saves the user time.

@adrinjalali
Copy link
Member Author

Does this look better now?

@BenjaminBossan
Copy link
Collaborator

Yes, I think it's much easier now for users to understand the benefit. Ideally, we can later get someone who doesn't know anything about skops to read it and give their feedback, since all of us are already biased.

I can merge now if or wait for @merveenoyan to review.

@adrinjalali
Copy link
Member Author

I think you could merge, not a big change here I think.

@BenjaminBossan BenjaminBossan merged commit 7b2d1bf into skops-dev:main Aug 9, 2022
@adrinjalali adrinjalali deleted the readme branch August 9, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve README
2 participants