ENH Card class: add repr and str methods #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #59 We decided that the "eval(repr(card)) == card" property is not necessary for our purposes.
Also: Ignore convergence warning
adrinjalali
reviewed
Aug 2, 2022
pyproject.toml
Outdated
| @@ -10,6 +10,7 @@ profile = "black" | |||
| filterwarnings = [ | |||
| "error::DeprecationWarning", | |||
| "error::FutureWarning", | |||
| "ignore::sklearn.exceptions.ConvergenceWarning", | |||
There was a problem hiding this comment.
I wouldn't add this here, it's quite a bad one to completely ignore I'd say.
There was a problem hiding this comment.
I reverted it.
This is just in case that aRepr is a singleton that affects other code.
adrinjalali
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
This looks quite good to me. I'll let @merveenoyan also have a look before merging.
merveenoyan
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #59
We decided not to follow the
eval(repr(card)) == cardconvention, as it wouldn't work here.