Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improve readme #48

Merged
merged 9 commits into from
Jul 25, 2022
Merged

DOC improve readme #48

merged 9 commits into from
Jul 25, 2022

Conversation

adrinjalali
Copy link
Member

Improving the README and adding a CONTRIBUTING guideline.

README.rst Outdated Show resolved Hide resolved
@adrinjalali
Copy link
Member Author

Ready for another review, and the README can be seen rendered as this: https://github.com/adrinjalali/skops/blob/readme/README.rst

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, only 2 minor issues.

CONTRIBUTING.rst Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
adrinjalali and others added 2 commits July 22, 2022 16:21
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
@adrinjalali
Copy link
Member Author

@BenjaminBossan CI is green now :)

@BenjaminBossan BenjaminBossan merged commit 4a328ab into skops-dev:main Jul 25, 2022
@adrinjalali adrinjalali deleted the readme branch July 25, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants