Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Improve typehints. #426

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

adrinjalali
Copy link
Member

I started replacing Sequence with list, and it ended up being a rabbit hole that I couldn't easily get out of.

It also did raise some legit issues, so not all too bad, but there's a certain part that I can't figure out how to fix.

If you get a chance, I'd appreciate your wisdom @BenjaminBossan

@BenjaminBossan
Copy link
Collaborator

I started replacing Sequence with list

Could you explain the reasoning? In general, for input arguments, it is preferred to use general types, so Sequence instead of list or tuple. For output types, it's the opposite. Was there a problem with Sequence?

but there's a certain part that I can't figure out how to fix.

Could you explain what parts? Failing CI seems to be unrelated.

@TamaraAtanasoska
Copy link

looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants