TST Add trust check to persistence performance test #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Our script to check that skops persistence is not too slow compared to pickle used trusted=True so far. However, this is not the recommended way of using skops -- ideally the check for trusted types should be performed, which theoretically could slow down persistence. This PR adds the check for trusted types to the script. Results Testing locally, there is only a small difference. For instance, for the slowest couple of tests, the added time was only 0.05 sec or less. On average across all estimators, the difference was 0.004 sec. or 30% slower. This relatively small increase means that the check for trusted types is fast compared to constructing the objects.
|
@skops-dev/maintainers ready for review |
adrinjalali
approved these changes
Apr 24, 2023
adrinjalali
changed the title
BenjaminBossan
deleted the
persistence-performance-test-with-checking-trusted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our script to check that skops persistence is not too slow compared to pickle used
trusted=Trueso far. However, this is not the recommended way of using skops -- ideally the check for trusted types should be performed, which theoretically could slow down persistence. This PR adds the check for trusted types to the script.Results
Testing locally, there is only a small difference. For instance, for the slowest couple of tests, the added time was only 0.05 sec or less. On average across all estimators, the difference was 0.004 sec. or 30% slower. This relatively small increase means that the check for trusted types is fast compared to constructing the objects.