FIX: Workflow file for persistence performance #326
Conversation
BenjaminBossan
commented
Mar 23, 2023
BenjaminBossan
commented
- wrong name
- trying to fix install
- wrong name - trying to fix install
|
@skops-dev/maintainers ready for review |
|
Could you please set this to trigger on PR so that we can test it here and see if the install actually fixes the issue? |
|
(don't merge yet) @adrinjalali While the fundamental issue still exists, I found a "solution" by copying the script to the project root inside the GH action. WDYT? |
|
Since this is to "fix" import issues, would it work if we do an But I'm happy to merge and revert once actions/setup-python#634 is resolved maybe? |
|
I don't see any advantage either way, so I just left it as is but added a comment to revert the change once the issue is solved. Also removed the PR hook, so this should be ready to be merged. |
| - name: Install requirements | ||
| run: | | ||
| pip install .[tests] | ||
| pip --version | ||
| pip list | ||
| - name: Run persistence performance checks | ||
| run: python scripts/check_persistence_performance.py | ||
| run: | | ||
| python3.11 scripts/check_persistence_performance.py |
There was a problem hiding this comment.
this probably can be python3 or even python, right? You can probably revert these two lines to what it was before actually.
All columns together exceed GH column width.
...in an attempt to get the column width down
|
@adrinjalali This works now, here is an output: https://github.com/skops-dev/skops/actions/runs/4531268169/jobs/7981214101?pr=326 I have removed the PR hook again, so we'll be 100% certain in 1 week :) |
