-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC make sklearn's estimator run in parallel in the intelex example #316
Conversation
Does intelex also use all cores? Otherwise, it's not an apples to apples comparison. Moreover, I see now that we initially missed incorrect reporting of log loss:
doesn't make sense, the f-string should not use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor formatting thing. There is one more :.1%
at the bottom of the doc.
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx.
On my local machine, this changes the speedup from 15 to 3. sklearn is not that slow.