Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC make sklearn's estimator run in parallel in the intelex example #316

Merged
merged 7 commits into from
Mar 13, 2023

Conversation

adrinjalali
Copy link
Member

On my local machine, this changes the speedup from 15 to 3. sklearn is not that slow.

@BenjaminBossan
Copy link
Collaborator

Does intelex also use all cores? Otherwise, it's not an apples to apples comparison.

Moreover, I see now that we initially missed incorrect reporting of log loss:

with a log-loss score of 21.7%

doesn't make sense, the f-string should not use %. Would you mind fixing that too?

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor formatting thing. There is one more :.1% at the bottom of the doc.

examples/plot_intelex.py Outdated Show resolved Hide resolved
examples/plot_intelex.py Outdated Show resolved Hide resolved
adrinjalali and others added 4 commits March 13, 2023 17:02
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx.

@BenjaminBossan BenjaminBossan merged commit 1f16f3e into skops-dev:main Mar 13, 2023
@adrinjalali adrinjalali deleted the intelex-example branch March 13, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants