Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI add codecov token to the config #312

Merged
merged 2 commits into from
Mar 7, 2023
Merged

CI add codecov token to the config #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a0c041
CI add codecov token to the config
adrinjalali Mar 7, 2023
33be150
add comment
adrinjalali Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,9 @@ codecov:
notify:
after_n_builds: 12
wait_for_ci: true
# the coverage is uploaded with or without a token. This only helps with some
# codecov errors. It's a recommended action from here:
# https://github.com/codecov/codecov-action/issues/837#issuecomment-1453877750
token: 2b8d4d69-6de6-4e1d-840a-5ccf9d849565
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a comment about why it's okay to include the token here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment.

ignore:
- "skops/_min_dependencies.py" # This file is not tested, and won't be.
1 change: 0 additions & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ jobs:
with:
env_vars: OS,PYTHON
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage.xml
flags: unittests
name: codecov-umbrella
Expand Down