MNT: Upgrade mypy to version 1.0.0 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade worked out of the box. I made a small change, however, to
adjust the signatures of Card to return the Self type, since this is now
supported by mypy.
Below is an example to illustrate why it's useful:
class Card1:
def add(self) -> Card1:
return self
class MyCard1(Card1):
pass
reveal_type(MyCard1().add()) # returns Card1 but should be MyCard1
class Card2:
def add(self) -> Self:
return self
class MyCard2(Card2):
pass
reveal_type(MyCard2().add()) # returns MyCard2
Note that pre-commit config has to be updated for this change as well.
|
ready for review @skops-dev/maintainers |
adrinjalali
reviewed
Feb 27, 2023
Comment on lines
+23
to
+26
| if sys.version_info >= (3, 11): | ||
| from typing import Self | ||
| else: | ||
| from typing_extensions import Self |
There was a problem hiding this comment.
is this another instance where mypy doesn't like it to be in fixes.py?
There was a problem hiding this comment.
Yes, it is indeed annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade worked out of the box. I made a small change, however, to adjust the signatures of
Cardto return theSelftype, since this is now correctly recognized by mypy.Below is an example to illustrate why it's useful:
Another advantage of upgrading is that mypy 1.0.0 should be faster. More in this post.
Note that pre-commit config has to be updated for this change as well.