Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC add PR prefixes to maintainer docs #282

Merged
merged 1 commit into from
Jan 24, 2023
Merged

DOC add PR prefixes to maintainer docs #282

merged 1 commit into from
Jan 24, 2023

Conversation

adrinjalali
Copy link
Member

Fixes #217

cc @skops-dev/maintainers

BenjaminBossan
BenjaminBossan approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, LGTM.

I don't think the final commit message necessarily has to be short, but that's a nit.

@BenjaminBossan BenjaminBossan merged commit 9bf557e into skops-dev:main Jan 24, 2023
@adrinjalali adrinjalali deleted the git-msg branch January 24, 2023 16:52
@adrinjalali
Copy link
Member Author

I agree, I don't mind longer messages you write, they're nice.

@BenjaminBossan BenjaminBossan changed the title DOC add PR preffixes to maintainer docs DOC add PR prefixes to maintainer docs Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add maintainers guide
2 participants
@adrinjalali @BenjaminBossan