Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on gradio and HF Hub #268

Merged

Conversation

BenjaminBossan
Copy link
Collaborator

@BenjaminBossan BenjaminBossan commented Jan 18, 2023

Following up the discussion on Slack.

@BenjaminBossan
Copy link
Collaborator Author

@merveenoyan can you please review?

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 💜

docs/hf_hub.rst Outdated
@@ -119,13 +119,15 @@ Easily build user interfaces to your scikit-learn models
--------------------------------------------------------
`gradio <https://gradio.app/>`__ is a python library that lets you create interfaces on your model.
It has a class called `Interface <https://gradio.app/docs/#interface>`__ that lets you create application
interfaces to your machine learning models.
interfaces to your machine learning models. Using gradio can have some advantages over the using a plain
model repository, e.g. the widget allows uploading a csv for tabular data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
model repository, e.g. the widget allows uploading a csv for tabular data.
model repository, e.g. the Gradio dataframe component allows uploading a csv for tabular data, unlike the widget in the model repository.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@merveenoyan merveenoyan merged commit 78c5ef4 into skops-dev:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants