Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Turn off CatBoost verbosity in tests #262

Merged

Conversation

BenjaminBossan
Copy link
Collaborator

By default, catboost prints a giant output to stdout when fitting. This is annoying when running the tests, which include fitting catboost. Normally, this does not matter, as pytest captures stdout, but when running pytest with -s (e.g. for debugging purposes or in CI), the output is flooded.

This PR adds verbose=False when initializing the catboost estimators, which prevents any output from being shown.

By default, catboost prints a giant output to stdout when fitting. This
is annoying when running the tests, which include fitting catboost.
Normally, this does not matter, as pytest captures stdout, but when
running pytest with -s (e.g. for debugging purposes or in CI), the
output is flooded.

This PR adds verbose=False when initializing the catboost estimators,
which prevents any output from being shown.
Copy link
Collaborator

@E-Aho E-Aho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can merge this in once the tests are done

@adrinjalali adrinjalali changed the title Turn off CatBoost verbosity in tests MNT Turn off CatBoost verbosity in tests Jan 5, 2023
@adrinjalali adrinjalali merged commit baa990a into skops-dev:main Jan 5, 2023
@BenjaminBossan
Copy link
Collaborator Author

Lightning fast reviews :D

@BenjaminBossan BenjaminBossan deleted the turn-off-catboost-verbosity branch January 5, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants