Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC rework persistence user guide #255

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

adrinjalali
Copy link
Member

Fixes #220.

This should better reflect the state of affairs now.

cc @skops-dev/maintainers

@adrinjalali
Copy link
Member Author

Also cc @thomasjpfan. This should address the comments you had.

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update. Only minor issues from my side.

docs/persistence.rst Outdated Show resolved Hide resolved
docs/persistence.rst Show resolved Hide resolved
docs/persistence.rst Outdated Show resolved Hide resolved
docs/persistence.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BenjaminBossan BenjaminBossan merged commit ba840d4 into skops-dev:main Dec 16, 2022
@adrinjalali adrinjalali deleted the persistence-docs branch December 16, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Update persistence docs to reflect latest audit changes
2 participants