Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT cleanup user links in the changelog #236

Merged
merged 1 commit into from
Dec 2, 2022
Merged

MNT cleanup user links in the changelog #236

merged 1 commit into from
Dec 2, 2022

Conversation

adrinjalali
Copy link
Member

For users who are not in the authors.rst list, they should be referred to with the :user: directive.

The _authors.rst file is only there for convenience so that for recurring contributors we don't have to repeat the :user: directive.

BenjaminBossan
BenjaminBossan approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, great.

@BenjaminBossan BenjaminBossan merged commit dc7d981 into skops-dev:main Dec 2, 2022
@adrinjalali adrinjalali deleted the changes-cleanup branch December 2, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @BenjaminBossan