Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fix clean_skops.py #235

Merged
merged 1 commit into from
Dec 2, 2022
Merged

CI fix clean_skops.py #235

merged 1 commit into from
Dec 2, 2022

Conversation

adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Dec 2, 2022 •
edited
Loading

Fixes #231

This fixes the broken clean_skops.py.

  • We can now pass the token to the client instance
  • The output of list_models is a generator now
  • Most models are private, so the token was required to list them, which were previously ignored

cc @skops-dev/maintainers

The script works locally now.

BenjaminBossan
BenjaminBossan approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@BenjaminBossan BenjaminBossan merged commit 53119d7 into skops-dev:main Dec 2, 2022
@adrinjalali adrinjalali deleted the clean-ci branch December 2, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean_skops.py job broken
2 participants
@adrinjalali @BenjaminBossan