Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update version of GH checkout action #232

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

BenjaminBossan
Copy link
Collaborator

@BenjaminBossan BenjaminBossan commented Dec 1, 2022

Version 4 should get rid of the deprecation warning:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I guess that's the deprecation that what Adrin meant in #231:

There's also a deprecation issue in the GH CI definition which needs to be fixed.

Here are all warnings from an older CI run:

https://github.com/skops-dev/skops/actions/runs/3592690842

Here they are from this PR:

https://github.com/skops-dev/skops/actions/runs/3593038193

So the deprecation is gone.

Ready for review @skops-dev/maintainers

Version 4 should get rid of the deprecation warning:

The `set-output` command is deprecated and will be disabled soon. Please
upgrade to using Environment Files. For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@E-Aho E-Aho merged commit b9e6580 into skops-dev:main Dec 1, 2022
@BenjaminBossan BenjaminBossan deleted the CI-update-gh-action-version branch December 1, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants