CI Relax dependency of HF hub being < v0.10 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That restriction was a short term solution because we thought we could make v0.10 work with a few changes. However, that's not the case because of a bug in HF hub model cards on Windows. This requires a bugfix release before it would be fixed. In the meantime, we should allow users to install v0.10, since there is no technical reason not to use it. The only annoyance is that users will get FutureWarnings. For CI, we filter out corresponding FutureWarnings for the time being. Once the HF hub bug is fixed, we can proceed with skops-dev#162 and remove the filter.
|
@skops-dev/maintainers ready for review, as discussed earlier. |
adrinjalali
reviewed
Oct 4, 2022
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
adrinjalali
approved these changes
Oct 4, 2022
adrinjalali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That restriction was a short term solution because we thought we could make v0.10 work with a few changes. However, that's not the case because of a bug in HF hub model cards on Windows. This requires a bugfix release before it would be fixed.
In the meantime, we should allow users to install v0.10, since there is no technical reason not to use it. The only annoyance is that users will get
FutureWarnings.For CI, we filter out corresponding
FutureWarnings for the time being. Once the HF hub bug is fixed, we can proceed with #162 and remove the filter.