ENH Added getting started snippet for .skops format #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Oct 4, 2022
| ) | ||
| if self.metadata.to_dict().get("model_file"): | ||
| model_file = self.metadata.to_dict().get("model_file") | ||
| if model_file.endswith(".skops"): |
There was a problem hiding this comment.
we shouldn't be relying on the extension of the file. We should add the format info to the metadata. Something like:
"model": {
"file": "model.pickle",
"format": "pickle" or "skops",
},
There was a problem hiding this comment.
I was thinking of this just yesterday when I was editing snippet on Hub 😅
I'm not relying on extensions much, as long as it's not .skops I assume it's pickle. People can't deserialize a pickle file with .load() anyway so it wouldn't work. But if you think people really can serialize a pickle with .skops extension, I will create the issue.
adrinjalali
approved these changes
Oct 4, 2022
adrinjalali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #165
The tests were a bit tricky given I couldn't directly create temporary file and save into it and already existing fixtures are serving to pickle format. I'll refactor them.