Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC add link to the hub with skops filter #129

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

adrinjalali
Copy link
Member

Fixes #127

cc @osanseviero @skops-dev/maintainers

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should probably address #114 soon to avoid showing so many CI-related repos.

@adrinjalali
Copy link
Member Author

CI finally green

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some links are broken. Maybe you can check if your editor has an RST mode with a command to add hyperlinks, since it's so easy to mess them up.

README.rst Outdated Show resolved Hide resolved
docs/hf_hub.rst Outdated Show resolved Hide resolved
merveenoyan and others added 3 commits September 7, 2022 10:40
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
@adrinjalali
Copy link
Member Author

hehe, sometimes my editor puts two backticks when I type one, annoying.

@BenjaminBossan
Copy link
Collaborator

@adrinjalali From my POV this can be merged but it needs to be updated.

@adrinjalali
Copy link
Member Author

@BenjaminBossan you need to change your "review" here for me to have the green button 😁

@BenjaminBossan BenjaminBossan merged commit ef7425a into skops-dev:main Sep 8, 2022
@adrinjalali adrinjalali deleted the hub-link branch September 8, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to the hub with all skops models filtered
3 participants