MNT Remove redundant test in CI

[BenjaminBossan]

As discussed, the "Tests" and "Doc Tests" tasks are redundant. Since CI
is already quite slow as is, we really don't want to run all the tests
twice. Therefore, the "Doc Tests" task is removed.

Ideally, we would have one task for only doctests and one for unit tests
but AFAICT, there is no option to only run doctests.

[BenjaminBossan]

@skops-dev/maintainers Ready for review (disregard false codecov complaint)

[merveenoyan]

Nice catch 🙂

[adrinjalali]

Aren't the options redundant with here?

skops/pyproject.toml

Lines 9 to 17 in ca853d4

	[tool.pytest.ini_options]
	filterwarnings = [
	"error::DeprecationWarning",
	"error::FutureWarning",
	]
	markers = [
	"network: marks tests as requiring internet (deselect with '-m \"not network\"')",
	]
	addopts = "--cov=skops --cov-report=term-missing --doctest-modules"

[BenjaminBossan]

Yes they are. I thought about removing the options there but then was unsure for the following reason: Is the main purpose of pyproject.toml to be for local development or for CI? If it's for the former, and we make a change that should only affect local development, we don't want to accidentally affect CI too. Therefore, I chose to have the options explicitly in CI (I assume that explicitly setting arguments takes precedence over the config file). If you think this distinction is not relevant, I can remove all redundant options.

[adrinjalali]

Interesting point of view. To me the point was to have it easier for people to have a local env more similar to the CI, so that the same tests are run with less effort. I personally added them there because I wanted to have them in the CI (definitely true for --doctest-modules).

[BenjaminBossan]

This is definitely a decision we can make -- running locally should be as close as possible to CI and the pyproject.toml should be the source of truth for that. It's just good to make that assumption explicit, so that we can be aware of that for the future.