ENH Add details tag in methods #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes skops-dev#107 When passing details_tag=True for figures or tables, those are now folded. Note that this does not work for content added via the add method, since that content relies on the existing template. Therefore, to change that, the template has to be changed.
|
@adrinjalali ready for review |
adrinjalali
reviewed
Aug 23, 2022
Yes, we can rename the argument. I wanted to use something that would have 0% chance of being actually intended as a section title. If you think "expandable" fits the bill, we can take that. I also thought about "folded" (like "code folding"), just to throw something else out there. |
|
yeah folded seems a better one to me. |
adrinjalali
approved these changes
Aug 23, 2022
adrinjalali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
When passing
details_tag=Truefor figures or tables, those are nowfolded.
Note that this does not work for content added via the add method, since
that content relies on the existing template. Therefore, to change that,
the template has to be changed.
To see the results, look here: