[#164119920, #164024212] audio integration updates for iOS #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemp296
reviewed
Feb 27, 2019
| NSInteger _status; | ||
| size_t _estimatedLength; | ||
| size_t _dataRecievd; | ||
| int _retryCount; | ||
| NSOutputStream* _outputStream; | ||
|
|
| @@ -54,6 +56,7 @@ @implementation UnityWWWConnectionDelegate | |||
| @synthesize connection = _connection; | |||
|
|
|||
| else | ||
| return "-Landscape"; | ||
| } | ||
| return ""; |
There was a problem hiding this comment.
why don't you need to check if it is orientable anymore? what happen if the game is force to always be a specific orientation?
|
All of the changes you're suggesting are inside of Unity-specific library files. They appear to be following their own logic and conventions, but I can provide reasons for each question you have |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio Integration changes for iOS CaveRunner.
Feature is fully functional and changes in volume persist through subsequent games
