Master v20.0 #35
Open
Master v20.0 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should be tracking .idea/ |
|
Same thing with local.properties, we shouldnt be tracking that |
armandgray
reviewed
Mar 29, 2018
bin/build-cave-runner.sh
Outdated
| @@ -12,11 +12,11 @@ printf "apiSecret=bc1e89c576f18f877c98d2ca8a922096ef5415a8b5023e922eb6b2c474a455 | |||
| sudo ln -sf /Users/opsadmin/Library/Android/sdk /usr/local/android-sdk-linux | |||
| # Compile Apps | |||
| # Clean dependencies so latest Skillz SDK is fetched | |||
| ./gradlew --refresh-dependencies | |||
| #./gradlew --refresh-dependencies | |||
There was a problem hiding this comment.
seems like teh comment above should be moved to where this is executed below and this commented line of code should be deleted
armandgray
reviewed
Mar 29, 2018
| compileSdkVersion 25 | ||
| buildToolsVersion "25.0.3" | ||
| compileSdkVersion 26 | ||
| buildToolsVersion '27.0.3' |
There was a problem hiding this comment.
i think these need to match, but according to greg you should be taking this line out anyways... not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.