Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription to events via WS broken #1391

Closed
dimalit opened this issue Feb 2, 2023 · 1 comment · May be fixed by #1392
Closed

Subscription to events via WS broken #1391

dimalit opened this issue Feb 2, 2023 · 1 comment · May be fixed by #1392
Assignees
@dimalit @sergiy-skalelabs
Labels
bug Something isn't working

Comments

@dimalit
Copy link
Contributor

dimalit commented Feb 2, 2023 •
edited
Loading

  1. run test https://github.com/skalenetwork/SkaleExperimental/blob/master/skaled-tests/test-events/contract-once.js
  2. it fails
    Commit that intruduced problem: 03fb35e

BAD logs:

2023-02-02 19:43:33.902854    >>> WS/0/RX >>> 261/0 peer ws://127.0.0.1 >>> {"id":2041676828,"jsonrpc":"2.0","method":"eth_sendRawTransaction","params":["0xf8c80183100000832dc6c094d34e38f8>
2023-02-02 19:43:33.903746    <<< WS/0/TX <<< 261/0 peer ws://127.0.0.1 <<< {"id":2041676828,"jsonrpc":"2.0","result":"0x4e34d3733f055ee757c403543258bd900f08bf6187221b6a24cc4cd24a8296e6"}
2023-02-02 19:43:33.923293    >>> WS/0/RX >>> 261/0 peer ws://127.0.0.1 >>> {"id":2041676829,"jsonrpc":"2.0","method":"eth_getTransactionReceipt","params":["0x4e34d3733f055ee757c403543258b>
2023-02-02 19:43:33.923543    <<< WS/0/TX <<< 261/0 peer ws://127.0.0.1 <<< {"id":2041676829,"jsonrpc":"2.0","result":null}
2023-02-02 19:43:33.944398    >>> WS/0/RX >>> 261/0 peer ws://127.0.0.1 >>> {"id":2041676830,"jsonrpc":"2.0","method":"eth_subscribe","params":["newHeads"]}
2023-02-02 19:43:33.944634    <<< WS/0/TX <<< 261/0 peer ws://127.0.0.1 <<< {"id":2041676830,"jsonrpc":"2.0","result":"0x20000002"}
2023-02-02 19:43:33.988804   Block sealed #9 (#340750ce…)
2023-02-02 19:43:33.993201   noteChanged: {0c4b6fad0f8b635c3c184857ecae9964a0b1b3ca363305bdf02e2e7cd62b4f8c, chain}
2023-02-02 19:43:33.993280   !!! 0 0c4b6fad…
2023-02-02 19:43:33.993500   Successfully imported 1 of 1 transactions
2023-02-02 19:43:33.993177    <<< WS/TX <<< 261/0 peer ws://127.0.0.1 <<< {"jsonrpc":"2.0","method":"eth_subscription","params":{"result":{"author":"0x0000000000000000000000000000000000000>
2023-02-02 19:43:33.993780    <<< WS/TX <<< 261/0 peer ws://127.0.0.1 <<< {"jsonrpc":"2.0","method":"eth_subscription","params":{"result":{"author":"0x0000000000000000000000000000000000000>

GOOD logs:

2023-02-02 19:30:18.192972    >>> WS/0/RX >>> 261/0 peer ws://127.0.0.1 >>> {"id":1443801862,"jsonrpc":"2.0","method":"eth_sendRawTransaction","params":["0xf8c80183100000832dc6c094d34e38f830736db41cc6e10aa37a3c851a7a2b..."]}
2023-02-02 19:30:18.193924    <<< WS/0/TX <<< 261/0 peer ws://127.0.0.1 <<< {"id":1443801862,"jsonrpc":"2.0","result":"0x4e34d3733f055ee757c403543258bd900f08bf6187221b6a24cc4cd24a8296e6"}
2023-02-02 19:30:18.213369    >>> WS/0/RX >>> 261/0 peer ws://127.0.0.1 >>> {"id":1443801863,"jsonrpc":"2.0","method":"eth_getTransactionReceipt","params":["0x4e34d3733f055ee757c403543258bd900f08bf6187221b6a24cc4cd24a8296e6"]}
2023-02-02 19:30:18.213615    <<< WS/0/TX <<< 261/0 peer ws://127.0.0.1 <<< {"id":1443801863,"jsonrpc":"2.0","result":null}
2023-02-02 19:30:18.234239    >>> WS/0/RX >>> 261/0 peer ws://127.0.0.1 >>> {"id":1443801864,"jsonrpc":"2.0","method":"eth_subscribe","params":["newHeads"]}
2023-02-02 19:30:18.234911    <<< WS/0/TX <<< 261/0 peer ws://127.0.0.1 <<< {"id":1443801864,"jsonrpc":"2.0","result":"0x20000002"}
2023-02-02 19:30:18.245315   Block sealed #9 (#b152d1c4…)
2023-02-02 19:30:18.248580   noteChanged: {0c4b6fad0f8b635c3c184857ecae9964a0b1b3ca363305bdf02e2e7cd62b4f8c, chain}
2023-02-02 19:30:18.248641   !!! 0 0c4b6fad…
2023-02-02 19:30:18.248799   Successfully imported 1 of 1 transactions
2023-02-02 19:30:18.249361   261/0 peer ws://127.0.0.1 <<< {"jsonrpc":"2.0","method":"eth_subscription","params":{"result":{"address":"0xd34e38f830736db41cc6e10aa37a3c851a7a2b82","blockHash":"0xb152d1c45f69619b02d30c676d78ec63d1be88da446e62cba486ab4af7c35eed","blockNumber":"0x9","data":"0x0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000e736f6d65206e65772076616c7565000000000000000000000000000000000000","logIndex":0,"topics":["0xe006253d6555267c58c862f2bc329f791539ba42a58806c10edfa17c77da8591"],"transactionHash":"0x4e34d3733f055ee757c403543258bd900f08bf6187221b6a24cc4cd24a8296e6","transactionIndex":0},"subscription":"0x0"}}

(last line is the key one - it's absent in the "bad" log)
@PolinaKiporenko PolinaKiporenko added the bug Something isn't working label Feb 3, 2023
@sergiy-skalelabs sergiy-skalelabs self-assigned this Feb 3, 2023
@sergiy-skalelabs sergiy-skalelabs linked a pull request Feb 3, 2023 that will close this issue
ticker-1391 - Fixes eth_subscription JSON format compatibility issue for web3.js #1392
Open
@DmytroNazarenko
Copy link
Collaborator

3.16.0-stable.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimalit dimalit

@sergiy-skalelabs sergiy-skalelabs

Labels
bug Something isn't working
Projects
SKALE Engineering 🚀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ticker-1391 - Fixes eth_subscription JSON format compatibility issue for web3.js skalenetwork/skaled
4 participants
@dimalit @DmytroNazarenko @sergiy-skalelabs @PolinaKiporenko