Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Backport sparse COO writer to 1.14 #3217

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

mojaveazure
Copy link
Member

Backport (cherry-pick) #3161 and #3204 to release-1.14 for use in downstream DelayedArray integration package

mojaveazure and others added 3 commits October 21, 2024 15:20
* [r] Add Arrow to R type mapper

Add new `r_type_from_arrow_type()` function to get R types from Arrow
types. This function takes an Arrow schema, field, or datatype and
returns the corresponding R type (as indicated by `typeof()`) (or types
for a schema)

[SC-57387](https://app.shortcut.com/tiledb-inc/story/57387)

* Update docs

* Update changelog
Bump develop version
* [r] Expose block/random writer for `SOMASparseNDArray`
Expose a COO writer to enable block/random writes for
`SOMASparseNDArrays`; allows downstream consumers to perform block or
random writes to sparse arrays

New SOMA methods:
 - `SOMASparseNDArray$.write_coordinates()`: write COO tables to a
   sparse array; replaces
   `SOMASparseNDArray$private$.write_coo_dataframe()`

[SC-57804](https://app.shortcut.com/tiledb-inc/story/57804)

* Fix rebase mess

* Update apis/r/R/SOMASparseNDArray.R

Co-authored-by: John Kerl <kerl.john.r@gmail.com>

* [code review
feedback](#3204 (comment))

* Move generalized integerish checking to a generic function
Add methods for
 - `bit64::integer64`
 - `arrow::DataType`
 - `arrow::Field`
 - `arrow::Array` and `arrow::ChunkedArray`

[code review
feedback](#3204 (comment))

* Update changelog
Bump develop version

---------

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
 - use old names for arrow schema helper
 - remove tests from non-backported functionality
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mojaveazure mojaveazure merged commit b5e7e01 into release-1.14 Oct 21, 2024
5 checks passed
@mojaveazure mojaveazure deleted the ph/backport-sparse-coo-writer branch October 21, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants