Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Add support for WKB and WKT attributes and dimensions #3210

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

XanthosXanthopoulos
Copy link
Collaborator

@XanthosXanthopoulos XanthosXanthopoulos commented Oct 20, 2024

This PR prepares the geometry dataframe support by enabling the use of WKB and WKT attributes and dimensions

@XanthosXanthopoulos XanthosXanthopoulos changed the title Add support for WKB and WKT attributes and dimensions [c++] Add support for WKB and WKT attributes and dimensions Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (60bdcf5) to head (2e77c7b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
+ Coverage   83.54%   83.65%   +0.11%     
==========================================
  Files          51       51              
  Lines        5434     5434              
==========================================
+ Hits         4540     4546       +6     
+ Misses        894      888       -6     
Flag Coverage Δ
python 83.65% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.65% <ø> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@XanthosXanthopoulos XanthosXanthopoulos marked this pull request as ready for review October 20, 2024 23:46
@XanthosXanthopoulos XanthosXanthopoulos merged commit 928c281 into main Oct 21, 2024
15 checks passed
@XanthosXanthopoulos XanthosXanthopoulos deleted the xan/wkb_support branch October 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants