Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove the no-longer-needed wrapper layers [WIP] #3209

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

johnkerl
Copy link
Member

These were useful during the cppification project -- they allowed us to migrate from tiledb-py-backed classes to libtiledbsoma-backed classes.

At this point, however, they simply add to the keystroking on all Python dev work. It's time to get rid of them, to save us all from needless copypasta in our development work moving forward.

Notes:

  • This PR is not ready for review.
  • This is biggish, and not done yet. I am almost always strongly attached to small/split-up PRs, for the benefit of the author as well as the reviewer. This one ... I'm not sure yet how to split it up.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (58ca2d0) to head (d411c39).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
+ Coverage   83.19%   83.79%   +0.60%     
==========================================
  Files          51       51              
  Lines        5504     5333     -171     
==========================================
- Hits         4579     4469     -110     
+ Misses        925      864      -61     
Flag Coverage Δ
python 83.79% <94.84%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.79% <94.84%> (+0.60%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant