Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix and refactor set_transform_to_* methods #3205

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Oct 18, 2024

The previous implementation of the set_transform_to_* methods in the Scene class had the validation on the transform input axes and output axes flipped. This fixes that bug and adds a generic set_transform_to_element method.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.33%. Comparing base (58ca2d0) to head (e79e21c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3205      +/-   ##
==========================================
+ Coverage   83.19%   83.33%   +0.13%     
==========================================
  Files          51       51              
  Lines        5504     5484      -20     
==========================================
- Hits         4579     4570       -9     
+ Misses        925      914      -11     
Flag Coverage Δ
python 83.33% <92.59%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.33% <92.59%> (+0.13%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark merged commit 89377d0 into main Oct 18, 2024
11 checks passed
@jp-dark jp-dark deleted the dark/fix-set_transform_to/sc-57990 branch October 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants