Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/c++] Remove tiledb-py from test_factory.py #3158

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Oct 9, 2024

Issue and/or context:

As part of #2883 to remove tiledb-py from unit tests

Changes:

  • Use the SOMA API to create objects and then modify the reserved metadata values; incorrect encoding versions and SOMA object types should still error out as before
  • Add force flag to delete_metadata to match set_metadata

* Use the SOMA API to create objects and then modify the reserved
metadata values; incorrect encoding versions and SOMA object types
should still error out as before
* Add `force` flag to `delete_metadata` to match `set_metadata`
@nguyenv nguyenv requested a review from johnkerl October 9, 2024 21:13
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (3a4426b) to head (216111c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3158      +/-   ##
==========================================
+ Coverage   82.96%   83.13%   +0.17%     
==========================================
  Files          50       50              
  Lines        5247     5247              
==========================================
+ Hits         4353     4362       +9     
+ Misses        894      885       -9     
Flag Coverage Δ
python 83.13% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.13% <ø> (+0.17%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

apis/python/src/tiledbsoma/common.cc Outdated Show resolved Hide resolved
apis/python/tests/test_factory.py Show resolved Hide resolved
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
@nguyenv nguyenv merged commit 397c68c into main Oct 10, 2024
15 checks passed
@nguyenv nguyenv deleted the viviannguyen/remove-tiledb-py-from-test-factory branch October 10, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants