Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Propagate Python/R function names to C++ for upgrade/resize methods #3130

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 4, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

  • This is underpinning for [python] New-shape testing for tiledbsoma.io [WIP] #2964
  • As @nguyenv pointed out, it might be nice for the C++ layer to just return enums only ...
  • ... but as I pointed out
    • informative messages really require specific context such as the user-provided shape and the limit it ran into
    • I don't want to write those all twice in Python and R
    • So we are making user-presentable strings in the C++ code
  • That said, we should not be hard-coding the function names from the caller -- given that C++ is creating user-facing error strings on behalf of Python and R, the C++ code should enable and empower the Python/R code to pass in their function names (whatever those are)

Notes for Reviewer:

Despite the line-count this is a trivial PR. I'm splitting out this PR (as well as recents #3125 #3127 #3130) in order to clear the picture for #2964 which is the contentful goal of my recent work this week.

@johnkerl johnkerl marked this pull request as ready for review October 4, 2024 15:39
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (47f6b73) to head (9b54d0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
+ Coverage   82.49%   82.60%   +0.11%     
==========================================
  Files          50       50              
  Lines        5204     5204              
==========================================
+ Hits         4293     4299       +6     
+ Misses        911      905       -6     
Flag Coverage Δ
python 82.60% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 82.60% <ø> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Oct 4, 2024

Thanks @nguyenv !

@johnkerl johnkerl merged commit 26b8929 into main Oct 4, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/cpp-can-resizers-names branch October 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants