Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Update coordinate space <-> JSON converters #3101

Merged

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Oct 1, 2024

  • Update transform_from_json and transform_to_json to support additional CoordinateSpace types UniformScaleTransform and ScaleTransform
  • Correct error message in PointCloud.coordinate_space setter

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (1b27a33) to head (693bd58).
Report is 2 commits behind head on spatial.

Additional details and impacted files
@@             Coverage Diff             @@
##           spatial    #3101      +/-   ##
===========================================
+ Coverage    80.29%   80.36%   +0.07%     
===========================================
  Files           49       49              
  Lines         5089     5093       +4     
===========================================
+ Hits          4086     4093       +7     
+ Misses        1003     1000       -3     
Flag Coverage Δ
python 80.36% <53.84%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 80.36% <53.84%> (+0.07%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Collaborator

@jp-dark jp-dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need to add these changes to the main branch now too.

* Update `transform_from_json` and `transform_to_json` to support
  additional `CoordinateSpace` types `UniformScaleTransform` and
  `ScaleTransform`
@nguyenv nguyenv force-pushed the viviannguyen/add-new-transform-types-in-spatial-util branch from 45937a1 to 693bd58 Compare October 1, 2024 21:47
@nguyenv
Copy link
Member Author

nguyenv commented Oct 1, 2024

Thanks! We'll need to add these changes to the main branch now too.

Does that mean I should merge this into main instead of spatial?

@nguyenv
Copy link
Member Author

nguyenv commented Oct 1, 2024

These changes are needed for #3110. I have these commits merged into that branch too.

@jp-dark
Copy link
Collaborator

jp-dark commented Oct 2, 2024

Thanks! We'll need to add these changes to the main branch now too.

Does that mean I should merge this into main instead of spatial?

It should be merged into both.

@nguyenv nguyenv merged commit b7d5c73 into spatial Oct 2, 2024
21 checks passed
@nguyenv nguyenv deleted the viviannguyen/add-new-transform-types-in-spatial-util branch October 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants