Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Remap indexes even if no new enums were added #2993

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Sep 13, 2024

Issue and/or context:

#2989 (comment)

Changes:

Always call remap indexes even if no new enumerations were added. These were done correctly in the specialized templates for string and Boolean types but needed to be added for the general case as well. Also add unit tests in Python to check for string and integer category value types.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (e7a21fd) to head (01e38e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2993      +/-   ##
==========================================
+ Coverage   89.64%   89.79%   +0.14%     
==========================================
  Files          39       39              
  Lines        4096     4096              
==========================================
+ Hits         3672     3678       +6     
+ Misses        424      418       -6     
Flag Coverage Δ
python 89.79% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
Thank you thank you!!! :)

@nguyenv nguyenv merged commit b3feada into main Sep 13, 2024
15 checks passed
@nguyenv nguyenv deleted the always-remap-indexes-for-enums branch September 13, 2024 21:21
@johnkerl johnkerl mentioned this pull request Sep 16, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants