Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove tiledb-py dependency #2752

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Jun 18, 2024

Issue and/or context:

#1632

This completes the SOMA Python API move over from tiledb-py to C++.

Changes:

  • Remove tiledb.ctx usage
  • Remove tiledb.Filter usage

@nguyenv nguyenv force-pushed the viviannguye/update-columns branch from 2820b03 to bc155cf Compare June 18, 2024 21:10
@nguyenv nguyenv force-pushed the viviannguye/update-columns branch from bc155cf to b672685 Compare July 30, 2024 14:34
@nguyenv nguyenv changed the base branch from viviannguye/update-columns to main August 12, 2024 21:32
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch 3 times, most recently from a07c48d to 017b1ec Compare August 12, 2024 22:36
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch from 017b1ec to 767c0b0 Compare August 12, 2024 22:48
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch 2 times, most recently from 7af640c to 30ea130 Compare October 15, 2024 00:55
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (d63a312) to head (4160a12).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   83.19%   83.66%   +0.47%     
==========================================
  Files          51       51              
  Lines        5504     5442      -62     
==========================================
- Hits         4579     4553      -26     
+ Misses        925      889      -36     
Flag Coverage Δ
python 83.66% <100.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.66% <100.00%> (+0.47%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [python] [NO MERGE UNTIL 1.14] Remove tiledb-py dependency [python] [NO MERGE UNTIL 1.15] Remove tiledb-py dependency Oct 15, 2024
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch 3 times, most recently from 0e92a8d to df6a892 Compare October 15, 2024 20:24
@nguyenv nguyenv changed the base branch from main to viviannguyen/various-tiledb-py-removals October 15, 2024 20:27
@nguyenv nguyenv changed the base branch from viviannguyen/various-tiledb-py-removals to main October 15, 2024 20:27
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch from df6a892 to 0aab84d Compare October 16, 2024 00:47
@nguyenv nguyenv marked this pull request as ready for review October 17, 2024 19:27
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch from f84c841 to 0e545db Compare October 18, 2024 00:38
@nguyenv nguyenv changed the title [python] [NO MERGE UNTIL 1.15] Remove tiledb-py dependency [python] Remove tiledb-py dependency Oct 18, 2024
@nguyenv nguyenv requested a review from johnkerl October 18, 2024 01:17
@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch 2 times, most recently from 6deb642 to f6946a1 Compare October 18, 2024 03:49
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@nguyenv nguyenv force-pushed the viviannguyen/goodbye-tiledb-py branch from f6946a1 to 4160a12 Compare October 18, 2024 16:37
@nguyenv nguyenv merged commit 642655c into main Oct 18, 2024
31 checks passed
@nguyenv nguyenv deleted the viviannguyen/goodbye-tiledb-py branch October 18, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants