-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Append-mode enum bit-width mods #2455
Conversation
c0aa0c4
to
1ba9b94
Compare
Update: @nguyenv 's recent cppification has fixed the case when a larger-bit-width enum exists on disk, with a smaller-bit-width append -- this now works correctly. The only remaining issue is: when a smaller bit width is done for the initial ingest, and then we overflow.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
==========================================
+ Coverage 89.87% 90.19% +0.31%
==========================================
Files 37 37
Lines 3941 3988 +47
==========================================
+ Hits 3542 3597 +55
+ Misses 399 391 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* [python] Append-mode enum bit-width mods [WIP] * lint * Fix remaining issue * unit-test updates * complete the unit-test mod
Issue and/or context: Presented in detail on #2456.
Changes: As on #2456.
Notes for Reviewer: See also updates below.