[python] Update to _create_or_open_coll for 1.2.7 compatibility
#1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1606 +/- ##
===========================================
+ Coverage 65.56% 91.09% +25.52%
===========================================
Files 109 34 -75
Lines 9221 2919 -6302
===========================================
- Hits 6046 2659 -3387
+ Misses 3175 260 -2915
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
[sc-33078] |
|
This pull request has been linked to Shortcut Story #33078: Backward compatibility for notebook workaround. |
johnkerl
changed the title
_create_or_open_coll for 1.2.7 compatibility [WIP]_create_or_open_coll for 1.2.7 compatibility
aaronwolen
approved these changes
Aug 18, 2023
|
This seems like it’s probably fine, but what is the motivation here? |
|
@thetorpedodog chatting you on Slack |
johnkerl
added a commit
that referenced
this pull request
Aug 18, 2023
) (#1619) * [python] Update to `_create_or_open_coll` for 1.2.7 compatibility * unit-test case Co-authored-by: John Kerl <kerl.john.r@gmail.com>
|
[sc-33078] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on #1592 did not cover enough cases.