-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Update to _create_or_open_coll
for 1.2.7 compatibility
#1606
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1606 +/- ##
===========================================
+ Coverage 65.56% 91.09% +25.52%
===========================================
Files 109 34 -75
Lines 9221 2919 -6302
===========================================
- Hits 6046 2659 -3387
+ Misses 3175 260 -2915
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
[sc-33078] |
This pull request has been linked to Shortcut Story #33078: Backward compatibility for notebook workaround. |
_create_or_open_coll
for 1.2.7 compatibility [WIP]_create_or_open_coll
for 1.2.7 compatibility
This seems like it’s probably fine, but what is the motivation here? |
@thetorpedodog chatting you on Slack |
) (#1619) * [python] Update to `_create_or_open_coll` for 1.2.7 compatibility * unit-test case Co-authored-by: John Kerl <kerl.john.r@gmail.com>
[sc-33078] |
Testing on #1592 did not cover enough cases.