Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Improve spec/impl consistency on cls/type/kind parameters #1045

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

atolopko-czi
Copy link
Member

Issue and/or context:
#834, #834 (comment)

Changes:
Use kind for collection type param in CollectionBase.add_new_collection()

Notes for Reviewer:

Use `kind` for collection type param in `CollectionBase.add_new_collection()`
@atolopko-czi atolopko-czi self-assigned this Mar 3, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +9.90 🎉

Comparison is base (1d5edee) 81.19% compared to head (ab25096) 91.10%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
+ Coverage   81.19%   91.10%   +9.90%     
==========================================
  Files          78       30      -48     
  Lines        4185     2259    -1926     
==========================================
- Hits         3398     2058    -1340     
+ Misses        787      201     -586     
Flag Coverage Δ
python 91.10% <100.00%> (-0.05%) ⬇️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/_collection.py 92.96% <100.00%> (ø)
apis/python/src/tiledbsoma/_tdb_handles.py 94.70% <0.00%> (-0.53%) ⬇️
inst/tiledb/include/tiledb/dimension.h
R/TileDBObject.R
src/include/tiledbsoma/array_buffers.h
inst/tiledb/include/tiledb/stats.h
inst/tiledb/include/tiledb/config.h
inst/tiledb/include/tiledb/deleter.h
src/include/tiledbsoma/managed_query.h
src/rutilities.cpp
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m somewhat surprised that mypy doesn’t complain about the name mismatch between cls and kind. I do have a companion change for the spec repo, but don’t let that change block this if we don’t need to.

@johnkerl johnkerl changed the title Improve spec/impl consistency [python] Improve spec/impl consistency on cls/type/kind parameters Mar 3, 2023
@atolopko-czi atolopko-czi merged commit a78b1e6 into main Mar 3, 2023
@atolopko-czi atolopko-czi deleted the atol/834-api-spec-compliance-fixes branch March 3, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants